Skip to content

issues: close #081 after PR #1196 was closed#1220

Merged
BigSimmo merged 7 commits into
mainfrom
cursor/ledger-081-closeout-6273
Jul 25, 2026
Merged

issues: close #081 after PR #1196 was closed#1220
BigSimmo merged 7 commits into
mainfrom
cursor/ledger-081-closeout-6273

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Jul 25, 2026 •
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Owner

Ledger-only correction. #081 was opened earlier today to warn that open PR #1196 would re-add the dual-listed AdmissionCommunityPts aliases and partially undo #30. PR #1196 was closed at 15:22 UTC on 2026-07-25 as superseded by #913 / current main (~680 commits behind, CONFLICTING), and its successor #1198 does not touch src/lib/eval-document-matching.ts.

The warning is therefore stale, and the underlying risk is now structurally guarded rather than merely watched: the generalized alias-disjointness and single-document contracts landed in PR #1215 fail closed if any later branch re-adds those aliases.

Change: move #081 from Open items to Resolved / archive with that outcome. One line removed, one line added; no other row, the queue, or the issues:next-id marker is touched. #080 (re-test the removed admission widening under an approved eval canary) stays open.

RAG impact: no retrieval behaviour change — documentation ledger only.

Checks: npm run format:changed, npm run docs:check-links (1182 references resolve), npm run verify:cheap (386 test files, 3421 tests passed).

Open in Web Open in Cursor 

Summary by CodeRabbit

  • Documentation
    • Added and initialized a resolved-issues archive section.
    • Updated issue #081 with its current resolution status and related safeguards.

@cursoragent @BigSimmo
issues: close #81 — PR #1196 closed, alias regression now contract-gu…
e863023 
…arded

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Jul 25, 2026

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Jul 25, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: abb33dca-964e-40fe-ad0c-355409c682c7

📥 Commits

Reviewing files that changed from the base of the PR and between 8e3a49d and 84a224b.

📒 Files selected for processing (1)
  • docs/outstanding-issues.md
📝 Walkthrough

Walkthrough

The outstanding-issues ledger adds a resolved/archive section and updates issue #081 with its closure, supersession context, and contract-based regression protection.

Changes

Issues ledger

Layer / File(s) Summary
Archive section and #081 resolution
docs/outstanding-issues.md		 Adds the resolved/archive ledger section and revises #081 to document PR supersession, successor scope, and alias-disjointness/single-document contracts.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title matches the main change: closing #081 after #1196 was superseded.
Description check ✅ Passed It states the change, rationale, verification results, and confirms no behavior change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cursor/ledger-081-closeout-6273

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Jul 25, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

@BigSimmo
BigSimmo enabled auto-merge (squash) July 25, 2026 16:54
@BigSimmo
BigSimmo merged commit e7e60c6 into main Jul 25, 2026
18 checks passed
@BigSimmo
BigSimmo deleted the cursor/ledger-081-closeout-6273 branch July 25, 2026 16:55
@BigSimmo BigSimmo mentioned this pull request Jul 25, 2026
Merged
cursor Bot pushed a commit that referenced this pull request Jul 25, 2026
@BigSimmo @cursoragent
docs: prlanded records for #1204/#1215/#1220 + fix the prlanded landi…
584b804 
…ng check (#1229)

* docs(ledger): record prlanded outcomes for PRs #1204, #1215, #1220

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

* docs(prlanded): compare trees against the squash commit, not three-dot main

Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

---------

Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
@BigSimmo BigSimmo mentioned this pull request Jul 25, 2026
Merged
@cursor cursor Bot mentioned this pull request Jul 25, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@BigSimmo @cursoragent